On Sun, 2005-02-20 at 02:05 +0200, Michael S. Tsirkin wrote: > Quoting r. Tom Duffy <[EMAIL PROTECTED]>: > > Subject: [PATCH][SDP][14/22] Whitespace cleanup in sdp_proto.h > > > > Signed-off-by: Tom Duffy <[EMAIL PROTECTED]> > > > > Index: linux-2.6.10-openib/drivers/infiniband/ulp/sdp/sdp_proto.h > > =================================================================== > > --- linux-2.6.10-openib/drivers/infiniband/ulp/sdp/sdp_proto.h > > (revision 1836) > > +++ linux-2.6.10-openib/drivers/infiniband/ulp/sdp/sdp_proto.h > > (working copy) > > @@ -599,14 +599,10 @@ static __inline__ int __sdp_inet_write_s > > I think we also should replace __inline__ with inline everywhere. > > Also, I think the convention is to add __ before inline functions > if they are an implementation detail and shouldnt be called > directly. > That does not seem to be the case for __sdp_inet_write_space, or for > other stuff in sdp_proto.h, so I think these functions shall have proper names > starting with an alphanumeric.
Yeah, I also don't like the convention of using _ in front of static functions. Those can be updated in the next set of patches ;) -tduffy
signature.asc
Description: This is a digitally signed message part
_______________________________________________ openib-general mailing list [email protected] http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
