On Thu, 2005-08-04 at 17:13 +0300, Or Gerlitz wrote: > Tom, > > Wouldn't it be simple to come with a patch that applies only to the > "dat" code ie > (gen2/trunk/src/linux-kernel/infiniband/ulp/kdapl/kdapl.h and/or api.c) > which does > not require --any-- code change at the cosumer side? > > that is, with the patch you sent, a call to dat_pz_create at in consumer > code was changed > > from > - ret = dat_pz_create (ia, &pz); > to > + ret = ia->common.provider->pz_create (ia, &pz); > > so cant it be done with dat_pz_create being a function (or define) > calling to > > ia->common.provider->pz_create(ia, &pz); > > similar to what is done by ib_core / libibverbs calling ib_mthca / > libmthca > > This makes the consumer code simpler and no changes are need in current > consumers
This is almost exactly what is there now. Not really a change. I don't like the multiple indirections to get to the function table, but this can be simplified later. Using the function table to call the function is a well established practice within the Linux kernel -- look at struct file_operations for a good example usage. -tduffy
signature.asc
Description: This is a digitally signed message part
_______________________________________________ openib-general mailing list [email protected] http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
