On Mon, 2005-10-17 at 12:42, Sean Hefty wrote: > >>+void agent_send_response(struct ib_mad *mad, struct ib_grh *grh, > > > > ^^^^ > > int > > > > Shouldn't this be left as int (and set error returns internal to this > > routine where they occur) ? There seem to be a number of them although > > the number has been reduced. > > From what I could see, this was only called from mad.c, which no longer uses > the return value.
Yes, but why not ? (I think that was also part of your change). At least, the errors should be indicated with printk's so it can be seen in the log what failure occured in agent_send_response (like failed ib_create_ah_from_wc or ib_create_send_mad or ib_post_send_mad). -- Hal _______________________________________________ openib-general mailing list [email protected] http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
