On Thu, Feb 23, 2006 at 12:27:05PM +0200, Or Gerlitz wrote:
> >>I'd say kill the non-SG case. We're in the progress of removing non-SG
> >>commands in the scsi midlayer, and I'm pretty sure they won't exist
> >>anymore before the iser code merged.
>
> >I wonder what would be the simplest patch to support it, does it make
> >sense to
> >use virt_to_page on sc->request_buffer to compose one entry SG on the
> fly
> >and use it down the code?
>
> Specifically, does something like makes sense?
>
> struct scatterlist my_sg; /* somewhere, but iser_send_command stack */
>
> if(!sc->use_sg) {
> my_sg.page = virt_to_page(sc->request_buffer);
> my_sg.length = sc->request_bufflen;
> my_sg.offset = 0;
> }
>
> now continue as ususal to process my_sg (it can't be on the stack
Yes, that makes sense for now. There's even a sg_init_one helper
to do the legwork for you. But before iser support goes into mainline
that'll be onbsolete already and can be removed again.
_______________________________________________
openib-general mailing list
[email protected]
http://openib.org/mailman/listinfo/openib-general
To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
