On Tue, 2006-03-07 at 13:04 -0800, Roland Dreier wrote: > > + ret = cxio_poll_cq(wq, &(chp->cq), &cqe, &cqe_flushed, &cookie, > > + &credit); > > I'm wondering about the driver architecture here. What is gained by > having iwch_poll_cq_one() call an inline function from another > module's header file, which in turn calls an exported function from > that other module? There are no other users of cxio_poll_cq() or > __cxio_poll_cq() so what is gained by this? > > Basically what is gained by splitting the driver into 3 pieces? > > - R.
This code, the rdma core module cxgb4rc.ko, was provided to me as a stand-alone module. The idea was to use that code elsewhere, like for rnic-pi. I left it as a module, but I can pull it into iw_cxgb3.ko. Now that rnic-pi and openib are merging, we don't need this as a stand-alone module at all. I'll pull it into the iw_cxgb3 module, but keep the C code layout as-is. Will that work? _______________________________________________ openib-general mailing list [email protected] http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
