> * Remove the multicast APIs from ib_sa.h. Multicast definitions are > * relocated from ib_sa to the ib_multicast module. (This provides > * cleaner encapsulation of the multicast services.)
I'm not sure about this -- does this lead to duplication of code like keeping track of outstanding requests? Or are you exporting some really low-level interface from ib_sa? Maybe the best thing to do is put the higher level multicast handling into the ib_sa module (and not export the current lower level multicast APIs any more). EXPORT_SYMBOL isn't totally free and if we're exporting really internal stuff for one other user (I'm guessing that you might be building on top of the sa_query.c::send_mad() level stuff), then we might as well just combine the multicast and SA modules into a single .ko (even if there are multiple .c files). Maybe ib_notice should just go into ib_sa as well. ...all of this is just based on speculating what you mean though. So more details would be in order at least. - R. _______________________________________________ openib-general mailing list [email protected] http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
