Hi, I just recognized, that the forward declaration is in the tree, so I'll send an updated version with the cleanup call.
Tschuss, ck On Thu, 25 Jan 2007 01:29:48 +0100 Segher Boessenkool <[EMAIL PROTECTED]> wrote: > >> +static int __devexit ipmi_of_remove(struct of_device *dev) > >> +{ > >> + /* should call > >> + * cleanup_one_si(dev->dev.driver_data); */ > >> + return 0; > >> +} > > > > If your remove doesn't work, don't implement one. > > As explained before, it's the underlying thing that doesn't > work. Yeah someone should fix it one day. Still it's better > to have this comment than to not have anything at all. An > XXX FIXME: tag wouldn't be out of place of course. > > > Though since you don't > > have the choice in having a module_exit or not, you should really > > implement one that works :-) > > Genau. > > > Segher > -- Mit freundlichen GrĂ¼ssen, kind regards, Christian Krafft IBM Systems & Technology Group, Linux Kernel Development IT Specialist ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Openipmi-developer mailing list Openipmi-developer@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openipmi-developer