On Thu, Jan 25, 2007 at 10:45:40AM +1100, Christian Krafft wrote: > This patch adds support for of_platform_driver to the ipmi_si module. > When loading the module, the driver will be registered to of_platform. > The driver will be probed for all devices with the type ipmi. It's supporting > devices with compatible settings ipmi-kcs, ipmi-smic and ipmi-bt. > Only ipmi-kcs could be tested. > > Signed-off-by: Christian Krafft <[EMAIL PROTECTED]> > Acked-by: Heiko J Schick <[EMAIL PROTECTED]> > > Index: linux/drivers/char/ipmi/ipmi_si_intf.c > =================================================================== > --- linux.orig/drivers/char/ipmi/ipmi_si_intf.c > +++ linux/drivers/char/ipmi/ipmi_si_intf.c > @@ -9,6 +9,7 @@ > * [EMAIL PROTECTED] > * > * Copyright 2002 MontaVista Software Inc. > + * Copyright 2006 IBM Corp., Christian Krafft <[EMAIL PROTECTED]> > * > * This program is free software; you can redistribute it and/or modify it > * under the terms of the GNU General Public License as published by the > @@ -64,6 +65,11 @@ > #include <linux/string.h> > #include <linux/ctype.h> > > +#ifdef CONFIG_PPC_OF > +#include <asm/of_device.h> > +#include <asm/of_platform.h> > +#endif
Adding this OF-specific code to the generic file doesn't look exactly nice. Is it possible to separate the code out to a separate ipmi_of.c file? > +static int __devexit ipmi_of_remove(struct of_device *dev) > +{ > + /* should call > + * cleanup_one_si(dev->dev.driver_data); */ Wo why doesn't it do that currently? :-) ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Openipmi-developer mailing list Openipmi-developer@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openipmi-developer