On Thu, Apr 17, 2025 at 03:54:09PM -0500, Corey Minyard wrote: > On Thu, Apr 17, 2025 at 06:58:21PM +0300, Andy Shevchenko wrote: > > On Thu, Apr 17, 2025 at 06:55:35PM +0300, Andy Shevchenko wrote: > > > On Wed, Apr 16, 2025 at 01:36:15PM -0500, Corey Minyard wrote: > > > > Andy reported: > > > > > > > > Debian clang version 19.1.7 is not happy when compiled with > > > > `make W=1` (note, CONFIG_WERROR=y is the default): > > > > > > > > ipmi_si_platform.c:268:15: error: cast to smaller integer type 'enum > > > > si_type' > > > > +from 'const void *' [-Werror,-Wvoid-pointer-to-enum-cast] > > > > It seems you copied'n'pasted from narrow screen. The lines should kept as is > > (as long as they are) without an additional line break and plus sign. > > Yep. Thanks Andy. Should this wait for for 6.16, or would 6.15 be > better?
I prefer v6.15, but it's not that critical, and v6.16 would work. So, up to you. > > > > 268 | io.si_type = (enum > > > > +si_type)device_get_match_data(&pdev->dev); > > > > Ditto. > > > > > > The IPMI SI type is an enum that was cast into a pointer that was > > > > then cast into an enum again. That's not the greatest style, so > > > > instead create an info structure to hold the data and use that. > > > > > > Tested-by: Andy Shevchenko <andriy.shevche...@linux.intel.com> -- With Best Regards, Andy Shevchenko _______________________________________________ Openipmi-developer mailing list Openipmi-developer@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openipmi-developer
