On Sat, 21 Mar 2026 00:49:56 GMT, Alexander Matveev <[email protected]>
wrote:
> - Fixed potential NULL pointer dereference.
> - Tested on all platforms with all supported media files.
modules/javafx.media/src/main/native/gstreamer/3rd_party/glib/gobject/gvaluecollector.h
line 270:
> 268: #define G_VALUE_COLLECT_SKIP(_value_type, var_args)
> \
> 269: G_STMT_START {
> \
> 270: GTypeValueTable *g_vcs_vtable = g_type_value_table_peek (_value_type);
> \
can you use `#ifdef` inside of `#define` to make the diff smaller and more
localized?
I am afraid of someone changing the original macro upstream and this will
silently break the one defined for `GSTREAMER_LITE`.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2122#discussion_r2977959764
