On Mon, 23 Mar 2026 22:32:01 GMT, Andy Goryachev <[email protected]> wrote:
>> - Fixed potential NULL pointer dereference.
>> - Tested on all platforms with all supported media files.
>
> modules/javafx.media/src/main/native/gstreamer/3rd_party/glib/gobject/gvaluecollector.h
> line 270:
>
>> 268: #define G_VALUE_COLLECT_SKIP(_value_type, var_args)
>> \
>> 269: G_STMT_START {
>> \
>> 270: GTypeValueTable *g_vcs_vtable = g_type_value_table_peek
>> (_value_type); \
>
> can you use `#ifdef` inside of `#define` to make the diff smaller and more
> localized?
>
> I am afraid of someone changing the original macro upstream and this will
> silently break the one defined for `GSTREAMER_LITE`.
No, compiler does not compile it. Also, as far as I know we cannot have `#`
inside `#define`. We already have several macros like that. Yes, it will brake,
but I am rechecking manually such conditions during merge. Not sure how else we
can patch macros.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2122#discussion_r2978050884
