Hi Steve,

In general it looks good but I want to correct some parts of it.

How should I proceed in this case?

Best regards,
Alexander Kouznetsov
(408) 276-0387

On 3 янв 2014 21:44, Stephen F Northover wrote:
Hi Alex,

Samples were changed to support Android. Apparently, hitting escape twice should exit an application and this behavior was coded into EnsembleApp. I'm not an Android guy but if this is standard Android behavior, it should be part of JFX, not the example code.

Anyhow, I'll let Stefan or Johan comment on this and they can enter a follow on JIRA.


On 2014-01-03 12:32 PM, hang...@oracle.com wrote:
Changeset: 6f0901527ad0
Author:    snorthov
Date:      2014-01-03 12:23 -0500
URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/6f0901527ad0

RT-35147: [Android, Ensemble8] App should react to hardware buttons on Android
Reviewed-by: snorthov
Contributed-by: Stefan Fuchs <snfu...@gmx.de>

! apps/samples/Ensemble8/src/app/java/ensemble/EnsembleApp.java
! apps/samples/Ensemble8/src/app/java/ensemble/PlatformFeatures.java
! apps/samples/Ensemble8/src/app/java/ensemble/samplepage/Description.java ! apps/samples/Ensemble8/src/app/java/ensemble/samplepage/SamplePageContent.java
! apps/samples/Ensemble8/src/app/java/ensemble/samplepage/SourceTab.java
! apps/samples/Ensemble8/src/app/java/ensemble/util/FeatureChecker.java
! modules/base/src/main/java/com/sun/javafx/PlatformUtil.java

Reply via email to