Did some investigation. Turns out the current applied gtk3 DND patch works - on the case of scenebuilder the dragview (the window that follows the mouse and shows an image/icon) is getting on the way.
It doesn't block drag destination from getting events on gtk2, but blocks on gtk3. Tried to fix it without success (for now). Posted question here: https://discourse.gnome.org/t/dnd-window-getting-in-the-way-of-dnd-events/1141 ________________________________ De: Kevin Rushforth <kevin.rushfo...@oracle.com> Enviado: segunda-feira, 10 de junho de 2019 19:00 Para: Thiago Milczarek Sayao; openjfx-dev@openjdk.java.net Assunto: Re: Call for testing: Drag and Drop on Linux > How much time we have until 13 release? The schedule is here [1]. RDP1 starts July 8 (aka "feature freeze") RDP2 starts Aug 5 Thanks. -- Kevin On 6/10/2019 1:53 PM, Thiago Milczarek Sayao wrote: > Hi Kevin, > > I will file a JBS with an explanation of the changes and why I did them. > > I did a lot of testing on DND on the last days and I have noticed that the > GTK3 DND fix that got integrated is not working completely with scenebuilder > (may affect other apps). The drag is ok, but when the pointer reach the drop > zone it's not detecting the mouse movement properly (it seems). I haven't > touched the "drop" code on either patches. > > In general I trust more the new patch because it has less #ifdefs and it's > more straightforward. But I understand your concerns. > > I will look into it (on the patch that got integrated). > > How much time we have until 13 release? Schedule is here [1]. RDP1 starts July 8 (aka "feature freeze") RDP2 starts Aug 5 -- Kevin [1] https://mail.openjdk.java.net/pipermail/openjfx-dev/2019-March/023180.html > > Thanks. > > > ________________________________ > De: Kevin Rushforth <kevin.rushfo...@oracle.com> > Enviado: segunda-feira, 10 de junho de 2019 17:39 > Para: Thiago Milczarek Sayao; openjfx-dev@openjdk.java.net > Assunto: Re: Call for testing: Drag and Drop on Linux > > Hi Thiago, > > I note that this is a significant change that touches more that just the > Drag and Drop code, so we will need a broader discussion of your > proposed enhancement, as we do with any significant change. Go ahead and > file an Enhancement request so that we have a JBS issue to track this. > Given where we are in the release cycle and the number of other > enhancements under review, this is out of scope for JavaFX 13, but could > be considered for a future release once there is general agreement of > the approach. > > One thing I recommend starting with is a high-level overview of the > changes. Also, an evaluation of whether (and how) this change might make > the Glass GTK port easier to maintain going forward would be helpful. > > Thanks. > > -- Kevin > > > On 6/10/2019 10:15 AM, Thiago Milczarek Sayao wrote: >> Dear Linux Users, >> >> I did some modifications on DND to work better with Linux: >> >> https://github.com/javafxports/openjdk-jfx/pull/490 >> >> Benefits: >> >> * Works on wayland >> * Works across gtk2 and gtk3 with little code differences >> * Works on scenebuilder (with gtk3 - currently it falls back to gtk2) >> * Will be easier to port to GTK4 when it's default (may take some >> time). >> >> I have tested on Ubuntu 16.04, 18.04 and 19.04. >> >> Please, give feedback on the Pull Request. >> >> On the source there are two test apps included (tests/manual/dnd). >> >> Can be also tested with scenebuilder (which uses drag and drop): >> >> * Clone de source https://github.com/gluonhq/scenebuilder >> * Build: gradlew build >> * Run: java --module-path <PATH TO OPENJFX >> SOURCE>/openjdk-jfx/build/sdk/lib --add-modules >> javafx.web,javafx.fxml,javafx.swing,javafx.media >> --add-opens=javafx.fxml/javafx.fxml=ALL-UNNAMED -cp >> app/build/libs/scenebuilder-11.0.0-SNAPSHOT.jar >> com.oracle.javafx.scenebuilder.app.SceneBuilderApp >> >> >> >>
