On Fri, 4 Oct 2019 06:13:48 GMT, Hadzic Samir <shad...@openjdk.org> wrote:
> Allright, this is a fix for JDK-8207957 > > ---------------- > > Commits: > - 969ebb51: Fixing TableColumnHeaderTest > - 9d379619: Removing Tablecolumnbasehelper > - 4fe020fc: Fix javadoc for TableColumnHeader > - c422c80f: Minor modification and uni test added. > - b2bdfb5b: Change resizeColumn to protected without static in order to be > able to override > - 3b9b7903: Second option for resizeColumnToFitContent in TableColumnHeader > - d91c56e5: First attempt to extract resizeColumnToFitContent > > Changes: https://git.openjdk.java.net/jfx/pull/6/files > Webrev: https://webrevs.openjdk.java.net/jfx/6/webrev.00 > Issue: https://bugs.openjdk.java.net/browse/JDK-8207957 > Stats: 523 lines in 4 files changed: 330 ins; 187 del; 6 mod > Patch: https://git.openjdk.java.net/jfx/pull/6.diff > Fetch: git fetch https://git.openjdk.java.net/jfx pull/6/head:pull/6 modules/javafx.controls/src/main/java/javafx/scene/control/skin/TableColumnHeader.java line 608: > 607: if (!tc.isResizable()) return; > 608: > 609: Object control = this.getTableSkin().getSkinnable(); see https://github.com/javafxports/openjdk-jfx/pull/289#discussion_r245482258 - this api still looks unhealthy .. PR: https://git.openjdk.java.net/jfx/pull/6