1. The Skara bot sends email to the openjfx-dev mailing list as a reply
to the RFR. Yes, this will lead to duplicate email for those on the
mailing list who are following the PR thread. I can't think of any way
to avoid this.
2. We don't need .hgignore any longer needed, but .hgtags has useful
historical data, so I wouldn't want to delete it. At some point we could
get rid of .hgignore as a cleanup task, but there is no hurry.
3. No plan that I am aware of, but it's an interesting question. I don't
know whether it would be feasible to have the Skara tooling enforce
this, but even if it were, identifying those changes that need a CSR
would still be a manual step. I would note that the bot also doesn't
know which PRs need a second reviewer, nor can it tell when all of the
outstanding concerns have been addressed. The bot does a baseline level
of checking, but ultimately it up to the Reviewer(s) and Committer to
ensure that a PR has met the criteria for integrating it.
4. Thanks for the update. As you say, the page could use some further
cleanup.
5. The only place I know of where we stated the general rule that
OpenJFX N is compatible with JDK N-1 or later is on the mailing list in
this thread [1]. And yes, the minimum version applies to running as well
as building. As of OpenJFX 13, the minimum is still JDK 11: we use JDK
12 as the boot JDK to build openjfx13, and run javac with "-source 11
-target 11". I am not aware of anything at this time that would motivate
us to bump the minimum to JDK 12 or JDK 13, but that's always a possibility.
-- Kevin
[1]
https://mail.openjdk.java.net/pipermail/openjfx-dev/2018-September/022534.html
On 10/10/2019 5:40 AM, Nir Lisker wrote:
Hi Kevin,
A few questions and comments:
1. I'm getting double notifications from threads I'm subscribed to -
one from GitHub and one from the bot, including notifications on my
own comments. The Skara bot doesn't need to notify me on threads I'm
subscribed to.
2. Are the hg files like hgignore and hgtags still needed in the
GitHub Skara repo?
3. Is there a plan for the bot to be CSR-aware? For example, add to
the checklist the CSR status when applicable?
4. I updated the build instructions page on the Wiki to remove the
Mercurial requirements and update the Git tools and repo address. The
page could use a cleanup for the sections "Before you start" and
anything below and including "Testing with JDK 9 or JDK 10".
5. Not directly Skara related, but I could not find where the rule
that OpenJFX is compatible with JDK N and N-1 is stated. I see that
the section "Contributing to the OpenJFX codebase" in Contributing.md
lists JDK 11 as the minimum, but doesn't it apply to users of the
library too?
- Nir
On Wed, Oct 2, 2019 at 4:52 PM Kevin Rushforth
<[email protected] <mailto:[email protected]>> wrote:
The openjdk/jfx repo is now open and accepting pull requests.
Refer to
the links in the included message below for more information.
One thing to note: there is not yet a CI job hooked up to the repo.
Contributors, Committers, and Reviewers need to take this into
account
when testing.
Please report any problems that you run into by replying to this
thread.
Thanks.
-- Kevin
On 10/1/2019 9:13 AM, Kevin Rushforth wrote:
> As announced in this message [1], we are transitioning the official
> openjfx mainline repo from Mercurial (hosted on
hg.openjdk.java.net <http://hg.openjdk.java.net>)
> to GIT (hosted on github.com <http://github.com>). Effective
immediately, the HG
> openjfx/jfx-dev/rt [2] repo is frozen. No more pushes to this repo
> will be accepted. Similarly, no more pull requests will be accepted
> against the GitHub javafxports/openjdk-jfx [3] sandbox repo.
>
> I have one final push to HG which will add the .jcheck/conf file
> needed by Skara [4]. I will do some sanity testing, and then the HG
> repo will be made read-only.
>
> I will send an announcement tomorrow morning when the new GitHub
> openjdk/jfx [5] repo is open for accepting pull requests. In the
mean
> time, you can fork and clone the new repo as indicated here [6] to
> prepare for this.
>
> Let me know if you have any questions.
>
> -- Kevin
>
> [1]
>
https://mail.openjdk.java.net/pipermail/openjfx-dev/2019-September/023551.html
> [2] http://hg.openjdk.java.net/openjfx/jfx-dev/rt
> [3] https://github.com/javafxports/openjdk-jfx
> [4] https://bugs.openjdk.java.net/browse/JDK-8231310
> [5] https://github.com/openjdk/jfx
> [6]
>
https://mail.openjdk.java.net/pipermail/openjfx-dev/2019-September/023558.html
