On Fri, 4 Oct 2019 23:03:00 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
> On Wed, 2 Oct 2019 20:02:22 GMT, Kevin Rushforth <k...@openjdk.org> wrote: > >> On Wed, 2 Oct 2019 19:54:50 GMT, Thiago Milczarek Sayao <tsa...@openjdk.org> >> wrote: >> >>> On Wed, 2 Oct 2019 19:54:50 GMT, Kevin Rushforth <k...@openjdk.org> wrote: >>> >>>> On Wed, 2 Oct 2019 19:54:48 GMT, Thiago Milczarek Sayao >>>> <tsa...@openjdk.org> wrote: >>>> >>>>> https://bugs.openjdk.java.net/browse/JDK-8225571 >>>>> >>>>> To run tests (on the root of the source tree): >>>>> ./gradlew apps >>>>> java @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar >>>>> dragdrop.DragDropWithControls >>>>> java @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar >>>>> dragdrop.DragDropColor >>>>> >>>>> java -Djdk.gtk.version=2 @build/run.args -cp >>>>> apps/toys/DragDrop/dist/DragDrop.jar dragdrop.DragDropWithControls >>>>> java -Djdk.gtk.version=2 @build/run.args -cp >>>>> apps/toys/DragDrop/dist/DragDrop.jar dragdrop.DragDropColor >>>>> >>>>> ---------------- >>>>> >>>>> Commits: >>>>> - 3d650b2b: Gtk DND port for Linux >>>>> >>>>> Changes: https://git.openjdk.java.net/jfx/pull/4/files >>>>> Webrev: https://webrevs.openjdk.java.net/jfx/4/webrev.00 >>>>> Issue: https://bugs.openjdk.java.net/browse/JDK-8225571 >>>>> Stats: 669 lines in 5 files changed: 81 ins; 442 del; 146 mod >>>>> Patch: https://git.openjdk.java.net/jfx/pull/4.diff >>>>> Fetch: git fetch https://git.openjdk.java.net/jfx pull/4/head:pull/4 >>>> >>>> @tsayao In your case `/covered` isn't what's needed. You have an OpenJDK >>>> ID so should do this instead: >>>> >>>>> If you already are an OpenJDK >>>>> [Author](https://openjdk.java.net/bylaws#author), >>>>> [Committer](https://openjdk.java.net/bylaws#committer) or >>>>> [Reviewer](https://openjdk.java.net/bylaws#reviewer), please click >>>>> [here](https://bugs.openjdk.java.net/secure/CreateIssue.jspa?pid=11300&issuetype=1) >>>>> to open a new issue so that we can record that fact. Please use "Add >>>>> GitHub user tsayao" as summary for the issue. >>> >>> Yes, noticed that while reading the comment again. I have opened an issue. >>> Thanks. >> >> @pankaj-bansal can you review this as well? > > Preliminary review was here: > [javafxports/openjdk-jfx/pull/490](https://github.com/javafxports/openjdk-jfx/pull/490) Just a reminder to take a look when time allows. PR: https://git.openjdk.java.net/jfx/pull/4
