On Mon, 9 Dec 2019 21:01:40 GMT, Kevin Rushforth <k...@openjdk.org> wrote:

>> The fix looks good to me.
>> 
>> I left a few minor comments, including adding a missing comma in the API 
>> docs, which will also need to be changed in the CSR. Once this is updated 
>> I'll review the CSR and then you can move the CSR to Finalize.
> 
> I would like both @aghaisas and myself to review / approve this. I will 
> sponsor it.
> 
> In addition, the CSR needs to be approved before this can be integrated.

Thanks for the review. I do not have access to a computer right now, I'll
update next week on Monday.

Le lun. 9 déc. 2019 à 17:01, Kevin Rushforth <notificati...@github.com> a
écrit :

> I would like both @aghaisas <https://github.com/aghaisas> and myself to
> review / approve this. I will sponsor it.
>
> In addition, the CSR needs to be approved before this can be integrated.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/openjdk/jfx/pull/6?email_source=notifications&email_token=ACEL43KWFAJ32FX3NNSM7ETQX2W3LA5CNFSM4I5EYYAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGKV3YQ#issuecomment-563437026>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ACEL43PNZLRK37IM33ROVGDQX2W3LANCNFSM4I5EYYAA>
> .
>

-------------

PR: https://git.openjdk.java.net/jfx/pull/6

Reply via email to