On Fri, 20 Dec 2019 23:43:53 GMT, Kevin Rushforth <[email protected]> wrote:
>> The pull request has been updated with 1 additional commit.
>
> The fix looks good now. There is one problem in the test (in
> `StubTextLayout`) that needs to be fixed.
Interesting. I was only running the tests in graphics (gradle :graphics:test)
as when I run all the tests I always get this failure (unrelated to anything
I've changed):
> Task :base:test
test.javafx.util.converter.LocalDateTimeStringConverterTest >
toString_to_fromString_testRoundtrip[0] FAILED
java.time.format.DateTimeParseException: Text '1985-01-12, 12:34 p.m.'
could not be parsed, unparsed text found at index 19
at
java.base/java.time.format.DateTimeFormatter.parseResolved0(DateTimeFormatter.java:2052)
at
java.base/java.time.format.DateTimeFormatter.parse(DateTimeFormatter.java:1877)
at
javafx.base/javafx.util.converter.LocalDateTimeStringConverter$LdtConverter.fromString(LocalDateTimeStringConverter.java:208)
at
javafx.base/javafx.util.converter.LocalDateTimeStringConverter.fromString(LocalDateTimeStringConverter.java:159)
at
test.javafx.util.converter.LocalDateTimeStringConverterTest.toString_to_fromString_testRoundtrip(LocalDateTimeStringConverterTest.java:131)
5222 tests completed, 1 failed, 27 skipped
-------------
PR: https://git.openjdk.java.net/jfx/pull/32
