On Tue, 14 Jan 2020 12:16:14 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> +1, Looks good to me. > > @effad - The extra commits and merge are no problem, provided that you want > to get this into openjfx15. > > However, if you intend to get this into openjfx14, as currently targeted in > JBS, then you will need to: > > 1. Rebase your `JDK-8236912` branch on top of the upstream `jfx14` branch > 2. Force-push your branch: `git push --force origin JDK-8236912` > 3. Edit this PR and change the target to the `jfx14` branch NOTE that this PR is not yet ready for integration. In addition to needing one more reviewer (me), there is the open question of which branch it should be targeted to. @effad I think that this should go into openjfx14, so the above steps I listed will allow for this. @guruhb can you please cancel your review (click the "re-request review" icon next to your review) until the above is done? ------------- PR: https://git.openjdk.java.net/jfx/pull/85
