On Thu, 20 Feb 2020 18:50:04 GMT, Nir Lisker <nlis...@openjdk.org> wrote:

>> The pull request has been updated with 1 additional commit.
> 
> modules/javafx.base/src/test/java/test/javafx/beans/property/ObjectPropertyLeakTest.java
>  line 111:
> 
>> 110:             origRefs.add(new WeakReference<>(origProp));
>> 111:             wrappedRefs.add(new WeakReference<>(wrappedProp));
>> 112:         }
> 
> I suggest extracting this section into its own method since it's being used 
> in all other tests.

Good idea. I'll do that.

-------------

PR: https://git.openjdk.java.net/jfx/pull/113

Reply via email to