> Issue JDK-8088198, where an exception would be thrown when trying to capture > a snapshot whose final dimensions would be larger than the running platform's > maximum supported texture size, was addressed in openjfx14. > The fix, based around the idea of capturing as many tiles of the maximum > possible size and re-compositing the final snapshot out of these, is > currently only attempted after the original, non-tiled, strategy has already > failed. > This was decided to avoid any risk of regressions, either in terms of > performances and correctness, while still offering some relief to the > original issue. > > This follow-on issue aims to propose a fix to the original issue, that is > able to correctly decide on the best snapshot strategy (tiled or not) to > adopt before applying it and ensure best performances possible when tiling is > necessary while still introducing no regressions compared to the original > solution.
The pull request has been updated with 1 additional commit. ------------- Added commits: - 9ec2d25c: Added comments to computeOptimumTileSize. Also, Ensure isDivExact is set to false if needed. Changes: - all: https://git.openjdk.java.net/jfx/pull/112/files - new: https://git.openjdk.java.net/jfx/pull/112/files/e13b5a06..9ec2d25c Webrevs: - full: https://webrevs.openjdk.java.net/jfx/112/webrev.01 - incr: https://webrevs.openjdk.java.net/jfx/112/webrev.00-01 Stats: 6 lines in 1 file changed: 6 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jfx/pull/112.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/112/head:pull/112 PR: https://git.openjdk.java.net/jfx/pull/112
