On Fri, 17 Apr 2020 09:21:25 GMT, Craig Cavanaugh <github.com+636962+ccavana...@openjdk.org> wrote:
>> The following should work: >> >> $ git rebase -i master >> >> If the rebase is successful, it will pop you into your EDITOR. You then >> select "pick" for the first commit (which is >> already selected by default) and "s"quash or "f"ixup for all subsequent >> commits. Then, if it looks good to you, do the >> following: $ git push --force origin 8129123 > > That did it! > > Thanks! > > On Thu, Apr 16, 2020 at 8:30 AM Kevin Rushforth <notificati...@github.com> > wrote: > >> The following should work: >> >> $ git rebase -i master >> >> If the rebase is successful, it will pop you into your EDITOR. You then >> select "pick" for the first commit (which is already selected by default) >> and "s"quash or "f"ixup for all subsequent commits. Then, if it looks good >> to you, do the following: >> >> $ git push --force origin 8129123 >> >> — >> You are receiving this because you were mentioned. >> Reply to this email directly, view it on GitHub >> <https://github.com/openjdk/jfx/pull/166#issuecomment-614622433>, or >> unsubscribe >> <https://github.com/notifications/unsubscribe-auth/AAE3QIRSLJFPKYG2F7B4VO3RM326XANCNFSM4MES2KIA> >> . >> I think, selection and scrolling are two separate operations. Here we use these two operations to achieve the desired result for ComboBox. It is nice to have behavior and I am OK with the fix. > Also, I believe JDK-8196037 is a duplicate of this issue. Please Note that - JDK-8196037 is not a duplicate of this issue as described in PR description. I have a minor comment regarding test. ------------- PR: https://git.openjdk.java.net/jfx/pull/166
