On Fri, 17 Apr 2020 10:38:06 GMT, Ajit Ghaisas <aghai...@openjdk.org> wrote:
>> Craig Cavanaugh has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update unit test for JDK_8129123 to check midpoint of the list > > modules/javafx.controls/src/test/java/test/javafx/scene/control/ComboBoxTest.java > line 2097: > >> 2096: first <= index && index <= last); >> 2097: >> 2098: index = LIST_SIZE - 1; > > You have tested first and last index selection. > It will be nice to have a case where we select index = LIST_SIZE/2 Agreed, mid point test added ------------- PR: https://git.openjdk.java.net/jfx/pull/166
