On Thu, 21 May 2020 10:22:18 GMT, Jeanette Winzenburg <faste...@openjdk.org> 
wrote:

>> modules/javafx.controls/src/test/java/test/com/sun/javafx/scene/control/infrastructure/ControlBehaviorTestExample.java
>> line 52:
>>> 51: @RunWith(Parameterized.class)
>>> 52: public class ControlBehaviorTestExample {
>>> 53:
>> 
>> This test does not execute when run as part of :controls:test. We need to 
>> rename this class (and file) name to end with
>> 'Test'. I tried doing it and lot of failures are seen.
>
> that's the point - they are examples of how-to use it and see our tasks :)
> 
> Will address your other comments in a minute - and add two real tests (on 
> skin/behavior memory leaks with the
> misbehaving classes removed: then we'll have both the passing classes and 
> informal ignores on what's going wrong.

added SkinMemoryLeakTest/BehaviorMemoryLeakTest as (more or less ;) outlined in 
the bug report: in the parameter list
we start with all controls/classes and then remove the failing explicitly. 
Future fixes of the leaking classes will
have to remove the fixed from the excluded.

Hmm ..  now probably should remove the xxTestExamples (there existence doesn't 
seem to have been clear enough anyway ;)

-------------

PR: https://git.openjdk.java.net/jfx/pull/223

Reply via email to