On Thu, 28 May 2020 15:23:38 GMT, Nir Lisker <[email protected]> wrote:
>> modules/javafx.graphics/src/main/java/javafx/animation/Animation.java line
>> 402:
>>
>>> 401: */
>>> 402: private void doSetCurrentRate(double value) {
>>> 403: if (currentRate != null || !areNearEqual(value,
>>> DEFAULT_CURRENT_RATE)) {
>>
>> The above javadoc comment block appears after the javadoc comments for the
>> private `currentRate` property variable and
>> before the public get/property methods for `currentRate`. This seems fragile
>> (although the API docs pick up the right
>> one), so I recommend making this an ordinary block comment (i.e., `/*`
>> rather than `/**`). Either that or move it below
>> the get/property methods (and add `@param value`).
>
> Doesn't the autogenerated JavaDoc for the `getX`, `setX` and `xProperty`
> methods work by matching the method name to
> the property name regardless of they location in the class?
> `doSetCurrentRate` shouldn't ever be able to interfere with
> that. I can add a `@param` anyway.
So it would seem. It still seems a bit fragile, but as long as it works, I
won't push the point (we are very
inconsistent on this).
-------------
PR: https://git.openjdk.java.net/jfx/pull/196
