On Fri, 12 Jun 2020 18:28:47 GMT, Phil Race <p...@openjdk.org> wrote:
>> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> use LinkedHashMap instead of HashMap >> Only store the pointer to the utf8 string if its creation was successful > > Marked as reviewed by prr (Reviewer). > As for the test, even if StubFont were updated to provide a real font, the > StubToolkit doesn't load Prism (so none of > the text rendering code is exercised). Do you think you could instead add a > simple test or two in the system tests > project instead (maybe one testing UTF16 chars and one with a 0 char)? I added a systemtest ------------- PR: https://git.openjdk.java.net/jfx/pull/249
