On Mon, 15 Jun 2020 09:08:14 GMT, Johan Vos <j...@openjdk.org> wrote:
>> This addresses https://bugs.openjdk.java.net/browse/JDK-8246348 > > Johan Vos has updated the pull request incrementally with one additional > commit since the last revision: > > Add test for testing Pango behavior with Character(0) and surrogate pairs tests/system/src/test/java/test/com/sun/javafx/font/freetype/PangoTest.java line 88: > 87: if (!launchLatch.await(TIMEOUT, TimeUnit.MILLISECONDS)) { > 88: throw new AssertionFailedError("Timeout waiting for > Application to launch"); > 89: } Somehow this comment was dropped from my previous comments... If you add `throws Exception` to this method, then the entire try/catch block can be replaced with: assertTrue("Timeout waiting for Application to launch", launchLatch.await(TIMEOUT, TimeUnit.MILLISECONDS)); ------------- PR: https://git.openjdk.java.net/jfx/pull/249
