On Wed, 22 Apr 2020 12:00:03 GMT, Florian Kirmaier <fkirma...@openjdk.org> wrote:
>> Changes requested by arapte (Reviewer). > > I don't think the class MeshManagerCacheLeakTest is a good base to write > monocle + native tests. > It required input/output parsing which would be a bit too much. > > In my latest commit, I've added a simple solution to how the test can be > reused. > On my side, both tests are always green, but I'm using a mac. > > > If one of the tests is unstable on windows, then it would be great if we > could consider it as 2 bugs, so this PR can be > finished. > Afterwards it would be great if someone else could continue the windows-bug > because I don't have a very productive > setup to work on it and I also don't really understand the native windows > code. Any updates about this PR? I run into this bug basically every time I check something for a memory leak, which is quite annoying. Edit: The rerequest review button seems to be not working ------------- PR: https://git.openjdk.java.net/jfx/pull/153