On Tue, 21 Jul 2020 12:33:28 GMT, Florian Kirmaier <fkirma...@openjdk.org> 
wrote:

>> I don't think the class MeshManagerCacheLeakTest is a good base to write 
>> monocle + native tests.
>> It required input/output parsing which would be a bit too much.
>> 
>> In my latest commit, I've added a simple solution to how the test can be 
>> reused.
>> On my side, both tests are always green, but I'm using a mac.
>> 
>> 
>> If one of the tests is unstable on windows, then it would be great if we 
>> could consider it as 2 bugs, so this PR can be
>> finished.
>> Afterwards it would be great if someone else could continue the windows-bug 
>> because I don't have a very productive
>> setup to work on it and I also don't really understand the native windows 
>> code.
>
> Any updates about this PR?
> I run into this bug basically every time I check something for a memory leak, 
> which is quite annoying.
> Edit: The rerequest review button seems to be not working

Once the last of the `jfx15` reviews and other critical reviews are out of the 
way, we'll get back to this for JavaFX
16.

-------------

PR: https://git.openjdk.java.net/jfx/pull/153

Reply via email to