On Fri, 24 Jul 2020 21:41:04 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Nir Lisker has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now >> contains 11 commits: >> - Merge branch 'master' into 8217472_Add_attenuation_for_PointLight >> - Attenuation and range changed internally to floats from doubles >> - Fixed shader compilation errors for 2 and 3 lights in es2 >> - Addressing review comments >> - Fixed whitespaces >> - Correction for indexes >> - Docs and year update >> - Merge remote-tracking branch >> 'nlisker/8217472_Add_attenuation_for_PointLight' into >> 8217472_Add_attenuation_for_PointLight >> - GL pipeline >> - Separate range from attenuation >> - ... and 1 more: >> https://git.openjdk.java.net/jfx/compare/4ec163df...2e1223ed > > High-level comments: > > 1. The API docs look good. If you change the public API to `@since 16` then > you can also update the CSR and move it to > the "Submitted" state. 2. I think it would be good to cleanup the performance > test and make it part of this PR, maybe > in `tests/performance` (which currently only has the not-very-useful > `VMPerformance` subdir) or `tests/manual`. 3. We > need some functional tests, ideally automated ones in `tests/system` > I also left a few inline comments. I haven't reviewed the shaders yet, so I > do that, in addition to further testing, > next week. @arapte > I verified it in the compiled D3D shader, that the change reduces one > multiplication instruction in most of the shaders. I'd like to know how you did that. ------------- PR: https://git.openjdk.java.net/jfx/pull/43
