On Wed, 19 Aug 2020 00:12:01 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Bhawesh Choudhary has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Marked few class constructor as deprecated as per review > > I think that two of the classes have implicit constructors that are there by > accident. Once we get agreement, I'll file > a follow-on bug for those, and those changes should be reverted. > As for the other comments, I would prefer a follow-up bug for any doc cleanup > that isn't part of adding in an explicit > constructor. Tempting as it might be to fix it, it seems out of scope. > That leaves the question about the wording. The more I think about it the > more I like what the JDK did as opposed to > what we did. The question then becomes: if we agree that it's a better > pattern, do we adopt it here and then clean it > up for the other two batches or just leave it as is for now, and file one > cleanup bug for later. I'd like to hear from > @aghaisas and @nlisker @bhaweshkc You can't deprecate the constructors in this PR since it will need a separate CSR. You should revert the changes on these classes completely and file a new bug (and CSR) dealing with deprecations. ------------- PR: https://git.openjdk.java.net/jfx/pull/283
