On Wed, 26 Aug 2020 12:03:26 GMT, Jeanette Winzenburg <faste...@openjdk.org> 
wrote:

>> Ambarish Rapte has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Corrections in test
>
> looks good :)

The fix looks good for an editable ComboBox.

If the ComboBox is not editable, it will have the effect of making the HOME and 
END keys no-ops, which is a (possibly
unwanted) change in behavior. I checked a couple native Windows apps and they 
have the behavior I would expect: the
arrow keys, and the HOME / END keys navigate the text field for editable combo 
boxes. HOME and END go to the beginning
or end of the list for non-editable combo boxes.

While we could treat that as a follow-up issue, it would be worth thinking 
about whether we could limit the change to
editable combo boxes.

-------------

PR: https://git.openjdk.java.net/jfx/pull/172

Reply via email to