On Tue, 27 Oct 2020 05:41:02 GMT, Ajit Ghaisas <aghai...@openjdk.org> wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/control/ComboBoxTest.java >> line 658: >> >>> 656: StageLoader sl = new StageLoader(comboBox); >>> 657: >>> 658: >> >> good catch :) But wouldn't show the stage have the same effect? (It's just >> me having a personal dislike of stageloader :) > > stage.show() has the same effect of fixing the bug. In fact, I fixed it > initially with exact this fix. > > When I looked at the other tests in ComboBoxTest class, I saw that there is a > pattern of creating a Stage, creating a Scene with ComboBox and then adding > Scene to the Stage. What was missed was stage.show(). The StageLoader does > exactly these steps (including the missed stage.show()). > StageLoader might be a misfit at some of the other places in our tests (I > believe that is the reason for your dislike), but I feel using StageLoader is > a better fit in ComboBoxTest. thanks! Wondering as to when/why Stageloader might be a misfit? I completely gave up on using it a while ago, so don't really remember *cough ------------- PR: https://git.openjdk.java.net/jfx/pull/337
