On Tue, 27 Oct 2020 11:30:23 GMT, Ajit Ghaisas <aghai...@openjdk.org> wrote:
>> just looked at MouseEventFirer (a bit late, sry ;): all it does is to >> dispose the Stageloader it created (if it received a bare node) - so if we >> add a node to a stage and/or wrap it into our own loader, we don't really >> need to dispose the firer (though it doesn't hurt except a very minimal code >> clutter) > > If we use our own loader - we would need to dispose that as well :) > > Also, I found approach (1) of using reference at test class level and > cleaning it up in cleanup method after the test is more suitable as in > ButtonTest, the assertion happens in event handler. Wrapping it in > try..finally will need additional code. > I will push the changes in a moment. nit-picking: we already do dispose our own loader (or cleanup our stage), don't we :) the change looks good ------------- PR: https://git.openjdk.java.net/jfx/pull/337
