On Wed, 20 Jan 2021 16:37:04 GMT, Kevin Rushforth <[email protected]> wrote:
>> By using the anchor location facility of PopupWindows we can avoid >> miscalculation of the >> menu's height entirely. >> This fix also cleans up some documentation issues. >> This fix introduces tests that check the correct positioning >> (test_position_*) >> test_position_withCSS reproduces the problem that is fixed with this patch. >> The other test_position_* cases serve as "proof" that no regressions are >> introduces. >> They work before and after the fix is introduced. > > This changes the specification in a way that will require prior discussion,. > It also will need a CSR. I recommend that you follow the instructions in the earlier comment about pushing these changes to a new branch, resetting your master branch, and creating a new PR from your new branch. ------------- PR: https://git.openjdk.java.net/jfx/pull/381
