On Wed, 20 Jan 2021 16:44:14 GMT, Robert Lichtenberger <[email protected]>
wrote:
>> I recommend that you follow the instructions in the earlier comment about
>> pushing these changes to a new branch, resetting your master branch, and
>> creating a new PR from your new branch.
>
>> I recommend that you follow the instructions in the earlier comment about
>> pushing these changes to a new branch, resetting your master branch, and
>> creating a new PR from your new branch.
>
> Ah yes, will try to do so tomorrow.
Regarding the spec change, I was thinking of this section, which you removed:
* To clarify the purpose of the {@code hpos} and {@code vpos} parameters,
* consider that they are relative to the anchor node. As such, a {@code
hpos}
* and {@code vpos} of {@code CENTER} would mean that the ContextMenu
appears
* on top of the anchor, with the (0,0) position of the {@code ContextMenu}
* positioned at (0,0) of the anchor. A {@code hpos} of right would then
shift
* the {@code ContextMenu} such that its top-left (0,0) position would be
attached
* to the top-right position of the anchor.
As you pointed out, the reference to `hpos` and `vpos` is incorrect, but unless
I'm missing something, it still seems like the concept still needs to be
described.
-------------
PR: https://git.openjdk.java.net/jfx/pull/381
