On Thu, 4 Feb 2021 20:04:39 GMT, Nir Lisker <nlis...@openjdk.org> wrote:
> The added test will look meaningless after the patch, since it's trying to > force a change that can't happen anymore, and this can be confusing in the > future. Does it still make sense to commit it? It's more of a demonstration > of the bug and the fix. This seems fine to me. We've done this sort of thing for other tests as well. > I also noticed that other tests in `LocalDateTimeStringConverterTest` are not > named with `test` in the beginning. Is this wrong? This is a loose naming convention that many classes follow, but many others do not, so it is not a problem. ------------- PR: https://git.openjdk.java.net/jfx/pull/393
