On Mon, 8 Mar 2021 22:00:14 GMT, John Neffenger <github.com+1413266+jgn...@openjdk.org> wrote:
>> It might be better to include the validation task in the same >> [`submit.yml`](https://github.com/openjdk/jfx/blob/master/.github/workflows/submit.yml) >> file as the pre-submit tests, as a separate job. That way it will get the >> same set of conditions triggering it as the other pre-submit jobs. In >> particular, we don't use the "on pull_request" trigger for our github >> actions run, since all actions triggered on any pull request in any repo in >> the openjdk org will be run in the context of the openjdk organization and >> we would blow our limits too quickly. Also, this should be limited to the >> set of branches that `submit.yml` uses. >> >> If there is a good reason to keep it in a separate file, then I would at >> least duplicate this part from submit.yml: >> >> on: >> # Run GitHub actions on every push to all branches except the main >> production branches, also >> # exclude any branch starting with "WIP". >> push: >> branches-ignore: >> - master >> - main >> - 'jfx[0-9]+' >> - 'WIP*' > > Thanks, Kevin. I'll merge the two workflow files. > > The test results aren't what I expected: > >  > > I assumed the wrapper validation would fail and prevent the builds from > running. Should I try to make the three build steps dependent on the success > of the wrapper validation? There might be a way to make the steps sequential > and conditional. If it isn't too hard to make the running of the other three jobs dependent on the wrapper validation job, that would be good, as long as the validation job is fast. The other three still need to run in parallel with each other. Alternatively, you could make the wrapper validation a task that is replicated in each of the three jobs. ------------- PR: https://git.openjdk.java.net/jfx/pull/419
