On Fri, 12 Mar 2021 09:01:49 GMT, Ambarish Rapte <ara...@openjdk.org> wrote:
>> Florian Kirmaier has updated the pull request incrementally with one >> additional commit since the last revision: >> >> JDK-8263322 >> updated the javadoc to mention the new case. > > tests/system/src/test/java/test/com/sun/javafx/application/InitializeJavaFXLaunchTest.java > line 2: > >> 1: /* >> 2: * Copyright (c) 2012, 2021, Oracle and/or its affiliates. All rights >> reserved. > > Minor year correction-> `Copyright (c) 2021,` > Similar change in other test files. Done, so it's the year where changes happened, ok! > tests/system/src/test/java/test/com/sun/javafx/application/InitializeJavaFXBase.java > line 96: > >> 94: } catch (Exception e) { >> 95: throw e; >> 96: } > > line 91: is non reachable code and second catch block is note required. Line 91 is reachable. Application.launch throws an IllegalStateException, even so, it doesn't declare it. I've Removed the second catch block. > tests/system/src/test/java/test/com/sun/javafx/application/InitializeJavaFXBase.java > line 33: > >> 31: import junit.framework.Assert; >> 32: import org.junit.BeforeClass; >> 33: import org.junit.Test; > > unused imports, BeforeClass and Test. removed! ------------- PR: https://git.openjdk.java.net/jfx/pull/421