On Wed, 10 Mar 2021 23:02:07 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8263322
>> updated the javadoc to mention the new case.
>
> tests/system/src/test/java/test/com/sun/javafx/application/InitializeJavaFXStartupTest.java
> line 46:
>
>> 44:
>> 45: @Test (timeout = 15000)
>> 46: public void testStartupThenLaunch() throws Exception {
>
> It will be more robust for these two test methods to be in separate files.
> Otherwise they might interfere with each other. If
> `testStartupThenLaunchInFX` runs first, then an error in that test (e.g., if
> the fix isn't applied and it times out) will cause the
> `testStartupThenLaunch` to fail. Conversely, if `testStartupThenLaunch` runs
> first, then the system is in a state where the Application has already been
> started by the time `testStartupThenLaunchInFX` runs. It will still pass, but
> won't be a solid test of the fix, since that case would fail today.
They are seperated now!
> tests/system/src/test/java/test/com/sun/javafx/application/InitializeJavaFXLaunchTest.java
> line 46:
>
>> 44:
>> 45: @Test (timeout = 15000)
>> 46: public void testStartupThenLaunch() throws Exception {
>
> It will be more robust for these two test methods to be in separate files.
> Otherwise they might interfere with each other.
They are seperated now!
-------------
PR: https://git.openjdk.java.net/jfx/pull/421
