On Thu, 25 Mar 2021 11:44:21 GMT, Jeanette Winzenburg <faste...@openjdk.org> wrote:
>> Fixing ListCell editing status is true, when index changes while editing. > > good catch, yet another property that's not correctly updated on index change > :) > > Quick questions: > - what are the macroscopic effects (that is in a running list) that you see > without fixing it? > - do we want mere cell re-use fire a editCancel? (which the list seems to > ignore in the test, don't know why) To clarify, this with happening with ListViews in production code. In some conditions, the status of a single cell doesn't update. The effect is, that a Cell is stuck in the Editing mode. If I remember correctly, it was irreversible stuck. It happened rarely, it might be connected to cells with variable sizes. Handling the logic from the ListView seems wrong to me, I think the ListCell should update its state automatically dependent of the properties. But I wouldn't know where to add it in the ListView. If that's how it's done in the other cell-based components, then it would make sense and the code more linear. I'm not really opinionated on how to solve it, just went for the simplest fix I've found. ------------- PR: https://git.openjdk.java.net/jfx/pull/441
