On Thu, 25 Mar 2021 23:11:28 GMT, Florian Kirmaier <fkirma...@openjdk.org>
wrote:
>
> Handling the logic from the ListView seems wrong to me,
looks like I was unclear, because that's a 100% me-too :)
Reformulating my second sentence in test snippets:
A:
cell.updateIndex(1);
list.edit(1);
cell.updateIndex(0);
// failing/passing before/after fix
assertFalse("cell re-use must update cell editing state" ,
cell.isEditing());
B:
List<EditEvent> events = new ArrayList<EditEvent>();
list.setOnEditCancel(e -> {
events.add(e);
});
.... setup test state as in A
// passing/failing before/after fix
assertTrue("cell re-use must not trigger edit events", events.isEmpty());
C:
.... setup test state as in A
// passing/passing before/after fix
assertEquals("cell re-use must not change list editing state", 1,
list.getEditingIndex);
My question was, whether we agree on B. My wondering was about C passing in the
light of B failing.
-------------
PR: https://git.openjdk.java.net/jfx/pull/441
