On Thu, 1 Apr 2021 23:23:37 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> We have a few in-flight or imminent updates that will impact this PR. There >> is a tight deadline on one of them (an ICU data file dependency), so I'd >> prefer to wait on integrating this until after they are done. >> >> It's still worth continuing the review in the mean time. I noticed that the >> libav bundles are missing on Linux. To ensure that you aren't missing any >> dependencies, can you add the following gradle flags to your build? >> >> -PCOMPILE_MEDIA=true -PBUILD_LIBAV_STUBS=true >> >> This will build the native media libraries, including the libav stubs (the >> latter is Linux only). Eventually, you will need to include WebKit, but >> that's not needed for now. > > When you build media with libav stubs on Linux, you should see the following > 5 new entries: > > ffmpeg-3.3.3-.tar.gz > ffmpeg-4.0.2-.tar.gz > libav-11.4-.tar.gz > libav-12.1-.tar.gz > libav-9.14-.tar.gz > > And I was right about the additional internal tools that I would need to add. > Here is the list: > > cmake-3.13.3-Darwin-x86_64.tar.gz > cmake-3.13.3-Linux-x86_64.tar.gz > cmake-3.13.3-win32-x86.zip > devkit-linux_x64-gcc10.2.0-OL6.4+1.0.tar.gz > devkit-macosx_x64-Xcode11.3.1-MacOSX10.15+1.0.tar.gz > devkit-windows_x64-VS2019-16.7.2+1.0.tar.gz > jfx-devkit-gcc-patch+1.1.tar.gz > ninja-win.zip > > When you build media with libav stubs on Linux, you should see the following > 5 new entries: > > ffmpeg-3.3.3-.tar.gz > ffmpeg-4.0.2-.tar.gz > libav-11.4-.tar.gz > libav-12.1-.tar.gz > libav-9.14-.tar.gz > > And I was right about the additional tools that I would need to add (as a > bonus I found an unused tool that I will eliminate). Here is the list: > > cmake-3.13.3-Darwin-x86_64.tar.gz > cmake-3.13.3-Linux-x86_64.tar.gz > cmake-3.13.3-win32-x86.zip > devkit-linux_x64-gcc10.2.0-OL6.4+1.0.tar.gz > devkit-macosx_x64-Xcode11.3.1-MacOSX10.15+1.0.tar.gz > devkit-windows_x64-VS2019-16.7.2+1.0.tar.gz > jfx-devkit-gcc-patch+1.1.tar.gz > ninja-win.zip > > And here is one that will show up after PR #450 is integrated: > > icudt-64l.zip > > > And here is one that will show up after PR #450 is integrated: > > icudt-64l.zip When you build media with libav stubs on Linux, you should see the following 5 new entries: ffmpeg-3.3.3-.tar.gz ffmpeg-4.0.2-.tar.gz libav-11.4-.tar.gz libav-12.1-.tar.gz libav-9.14-.tar.gz I'll let you add them. And I was right about the additional internal tools that I would need to add. Here is the list: cmake-3.13.3-Darwin-x86_64.tar.gz cmake-3.13.3-Linux-x86_64.tar.gz cmake-3.13.3-win32-x86.zip devkit-linux_x64-gcc10.2.0-OL6.4+1.0.tar.gz devkit-macosx_x64-Xcode11.3.1-MacOSX10.15+1.0.tar.gz devkit-windows_x64-VS2019-16.7.2+1.0.tar.gz jfx-devkit-gcc-patch+1.1.tar.gz ninja-win.zip I'll provide the sha256 sums once I've tested this (probably next week). Speaking of which, we will do a compiler update shortly after JDK 17 does theirs (should be pretty soon for Mac and Windows anyway), which will update the devkits. (as a bonus I found an unused tool that I will eliminate) And here is one more for WebKit that will show up after PR #450 is integrated: icudt-64l.zip This, and then its successor when we update ICU, are the main reason I want to hold off on this for 2-3 more weeks. ------------- PR: https://git.openjdk.java.net/jfx/pull/437
