On Tue, 6 Apr 2021 12:18:49 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Marius Hanl has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8263807: Code review changes > > The fix and test look fine. There is one needed change as noted below. > > > Thanks for the explanation. I'll finish my review shortly. > > > Isn't jcheck running all the tests anyway? > > You mean GitHub Actions (jcheck doesn't build or run any tests). It would, > but for two things: > > 1. You used the `master` branch of your repo, which is not recommended, > and will cause problems for you if you ever do another pull request. See > [this > comment](https://github.com/openjdk/jfx/pull/432#issuecomment-801982830) > added by the Skara bot. > > 2. You haven't enabled GitHub action on your personal fork of the `jfx` > repository. See > [wiki.openjdk.java.net/display/SKARA/Testing](https://wiki.openjdk.java.net/display/SKARA/Testing) > for information on how to enable it. Oh okay, thanks for the clarification. Interesting enough I don't need to enable Github actions, they are already enabled for all other branches I pushed. I think because I forked OpenJFX after you added them. But as you mentioned they are not running for master. I pushed a separate branch based of master (so only this 2 commits made by me), the Github actions were successful: https://github.com/Maran23/jfx/actions/runs/723063232 ------------- PR: https://git.openjdk.java.net/jfx/pull/432
