On Fri, 9 Apr 2021 11:35:01 GMT, Florian Kirmaier <fkirma...@openjdk.org> wrote:
>> Suggested a minor change. >> The test file has an existing test `memoryTest()`. The `AfterClass` and >> `BeforeClass` methods are specific to this test, and not related to the new >> test. It looks little unstructured with addition of this new test. Not sure >> if it is worth to change the helper methods and existing test. >> otherwise the fix and test looks good. > > I've now reworked the old test. The initialization of JavaFX is now seperated > of the old test. > The old test is now also much simpler. It no longer "jumps around" between > different methods. > The waiting for the Stage to be shown is also no longer necessary, which > simplifies it even more. Also no longer WeakReferences are needed for the test due to the new memory tests. No more worrying whether it can become null at the wrong moment. ------------- PR: https://git.openjdk.java.net/jfx/pull/455
