On Thu, 22 Apr 2021 23:25:23 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> That's a good question. >> OnShown is usually called in about 1 Frame. >> The memory-leak test takes some times, usually longer as 1 Frame. >> In the current configuration, it takes up to 1 seconds, with up to 10 checks. >> Because the check is so much longer, waiting for onShown doesn't really make >> a difference. > > My worry isn't the test might fail and give a false positive. The checking 10 > times will be sufficient for that. > > My concern is that since this bug fix is fixing a leak that only happens when > the stage is showing, the test might miss a potential leak if a regression in > this area were ever reintroduced. I think it's best to restore the wait for > onShown. I've readded the wait onShown. I don't really see a Scenario were this makes a difference, but i guess it's more correct, because it now tests it at the moment, where the object should be free, and not relying on the fact, that the check takes some time. ------------- PR: https://git.openjdk.java.net/jfx/pull/455
