On Sat, 27 Mar 2021 18:49:32 GMT, Bernhard M. Wiedemann 
<github.com+637990+bmwiedem...@openjdk.org> wrote:

> Sorted output still complies with that API, though.

Well, that's true. I hadn't thought of it that way.

I have tried twice and failed to [add you as a 
contributor](https://github.com/openjdk/jfx/pull/422#issuecomment-806317783) to 
my follow-up pull request. The only option left is the syntax "contributor add 
J. Duke <d...@openjdk.org>", but I'm not sure whether you want the e-mail 
address in your GitHub profile made public. Let me know whether I should pursue 
the problem.

If you're added, it puts your name and address in the commit log with 
`Co-authored-by` like this example:


commit 8adbc673d095607e8a6109fbb951fa17b9d6caad (tag: 17+3)
Author: Alexander Matveev <almat...@openjdk.org>
Date:   Mon Mar 15 20:57:19 2021 +0000

    8257895: Allow building of JavaFX media libs for Apple Silicon
    
    Co-authored-by: Johan Vos <j...@openjdk.org>
    Reviewed-by: jvos, kcr


It might be useful to have a previous commit if you plan to contribute to the 
OpenJFX project in the future.

-------------

PR: https://git.openjdk.java.net/jfx/pull/99

Reply via email to