On Thu, 15 Apr 2021 07:22:29 GMT, Ajit Ghaisas <aghai...@openjdk.org> wrote:
>> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Process reviewer comments > > modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/VirtualFlowTest.java > line 658: > >> 656: * laid out properly. >> 657: */ >> 658: @Test > > Only new line is added after @Test tag. There are a lot of changes of this > type which I presume were done by the IDE. I think, we can revert these > safely as not to cause unnecessary diffs. reverted > modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/VirtualFlowTest.java > line 1294: > >> 1292: vf.scrollPixels(-50); >> 1293: double neg = vf.getPosition(); >> 1294: assertFalse("Moving in negative direction should not decrease >> position", neg > pos); > > "decrease" in log message should be "increase" typos fixed ------------- PR: https://git.openjdk.java.net/jfx/pull/398