On Fri, 16 Apr 2021 09:00:19 GMT, Johan Vos <j...@openjdk.org> wrote:
>> This PR introduces a refactory for VirtualFlow, fixing a number of issues >> reported about inconsistent scrolling speed (see >> https://bugs.openjdk.java.net/browse/JDK-8089589) >> The problem mentioned in the JBS issue (and in related issues) is that the >> VirtualFlow implementation depends on cell index and cell count, instead of >> on pixel count. The latter is unknown when the VirtualFlow is created, and >> pre-calculating the size of a large set of items would be very expensive. >> Therefore, this PR uses a combination of a gradual calculation of the total >> size in pixels (estimatedSize) and a smoothing part that prevents the >> scrollback to scroll in the reverse direction as the requested change. >> This PR currently breaks a number of tests that hard-coded depend on a >> number of evaluations. This is inherit to the approach of this PR: if we >> want to estimate the total size, we need to do some additional calculations. >> In this PR, I try to balance between consistent behavior and performance. > > Johan Vos has updated the pull request incrementally with one additional > commit since the last revision: > > Process reviewer comments modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/VirtualFlowTest.java line 237: > 235: * the entire width/height of the VirtualFlow. > 236: */ > 237: @Test This file still has few more unintentional @Test tag followed by newline changes. modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/VirtualFlowTest.java line 528: > 526: * Tests that changes to the vertical property will clear the > maxPrefBreadth > 527: */ > 528: //@Test Is this @Test tag commented unintentionally? ------------- PR: https://git.openjdk.java.net/jfx/pull/398
