On Wed, 6 May 2020 20:37:10 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
> This is a toolchain upgrade on Windows from the current Visual Studio 2017 > (version 15.9.16) to Visual Studio 2019 (version 16.5.3). This will match a > recent upgrade done for JDK 15 -- see > [JDK-8244214](https://bugs.openjdk.java.net/browse/JDK-8244214). > > I have run a full build and test using this new compiler. > > NOTE: although this isn't strictly dependent on > [JDK-8244487](https://bugs.openjdk.java.net/browse/JDK-8244487), which is out > for review as PR #211 , I plan to wait until that one is approved. I will > then integrate PR #211 followed by this PR. I am not a big fan of scripts in a source code repository, unless they are automatically tested with every commit. Scripts are good candidates for being outdated soon, and often contain bitrotten code. We strive towards excellent code quality in the repository, and towards a very high test coverage for this code. If we can't achieve the same quality for scripts (which I believe is extremely hard to do), I am in favor of splitting of those scripts -- and maybe have them in a separate repository, maintained by different people? ------------- PR: https://git.openjdk.java.net/jfx/pull/212
